Skip to content

Conversation

@mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Oct 30, 2025

What type of PR is this?

/kind cleanup
/kind api-change

What this PR does / why we need it:

v1beta2: drop deprecated Flavors field from LocalQueueStatus

Which issue(s) this PR fixes:

Part of #7247

Special notes for your reviewer:

Does this PR introduce a user-facing change?

v1beta2: drop deprecated Flavors field from LocalQueueStatus

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 30, 2025
@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 7ada6d7
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6904a236f11d39000812ccd8
😎 Deploy Preview https://deploy-preview-7449--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 30, 2025
@mbobrovskyi mbobrovskyi force-pushed the cleanup/remove-deprecated-LocalQueueFlavorStatus branch 2 times, most recently from 8c25c3b to 0ee6022 Compare October 30, 2025 23:07
@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

/lgtm
/approve
This was discussed at wg-batch meetings 9th Oct and 23 Oct. Assuming lazy consensus for the change since no objections.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 23a534c008c1377d34a62692108483308694dcbf

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 31, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

@mbobrovskyi please rebase

@mbobrovskyi mbobrovskyi force-pushed the cleanup/remove-deprecated-LocalQueueFlavorStatus branch from 0ee6022 to c531b31 Compare October 31, 2025 10:20
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mimowo October 31, 2025 10:20
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2025
@mbobrovskyi
Copy link
Contributor Author

@mbobrovskyi please rebase

Done

@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 694d5b2fd8c0f37e57dd799ba75689c29203adb6

@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2025
@tenzen-y
Copy link
Member

@mbobrovskyi could you rebase again?

@mbobrovskyi mbobrovskyi force-pushed the cleanup/remove-deprecated-LocalQueueFlavorStatus branch from c531b31 to 7ada6d7 Compare October 31, 2025 11:49
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 31, 2025
@mbobrovskyi
Copy link
Contributor Author

@mbobrovskyi could you rebase again?

Done

@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f2bb8ccfe47c5e544f0f2feea8d263c7ccd351cf

@k8s-ci-robot k8s-ci-robot merged commit 41cc40a into kubernetes-sigs:main Oct 31, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Oct 31, 2025
@mbobrovskyi mbobrovskyi deleted the cleanup/remove-deprecated-LocalQueueFlavorStatus branch October 31, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants