Promote AdmissionFairSharing to beta #7463
Conversation
k8s-ci-robot
added
release-note
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
cncf-cla: yes
Updates the AdmissionFairSharing feature to beta status for v0.15: - Update KEP status to implementable and stage to beta - Enable feature gate by default in beta (v0.15) - Update documentation to reflect beta status - Simplify test setup for feature gate configuration - Add beta milestone to feature gate table 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
kannon92
force-pushed
the
promote-admission-fair-sharing-beta
branch
from
00e4efe to
af4f649
Compare
|
/retest known issue. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
@mimowo @kannon92 Do you know if K8s has any policy for agent co-author commit? I'm wondering if we should remove the Agent co-author message |
I don't know, maybe @BenTheElder knows? We can also ask on k8s infra. I suppose it is ok, but indeed it might be better to adjust the PR until we get a confirmation. Thanks for spotting. |
k8s-ci-robot
added
the
do-not-merge/hold
|
cc @mwysokin who may also have some knowledge here |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 858a0626f5965158461be350c5b8b1b6057beb52
|
I don't believe there is a policy in place. Generally commit mesaages that acknowledge use of AI is viewed favorably in other OSS projects. CLA passed so I think it's fine as I'm still pushing the commit under my account so my CLA credentials are enough. |
do we have such PRs in the core k8s repo? |
Yes, I think so it is ok, but I would like to get some confirmation from someone knowledgeable about the copyright issues |
|
I asked about the policy on slack k8s-org-members. |
https://github.com/kubernetes/kubernetes/pull/133659/commits |
|
I will update the commit to drop claude so this PR proceeds. I don't think this is necessary based on our policies and historical precedence. But I don't want that to block the merging of this PR. |
since such PRs get merged i to core k8s I dont think we need tk be more strict in Kueue. I consulted this with @BenTheElder and it is ultimately on the cncf. If the CLA check passes then we should be good in kueue as a project. Robots can open PRs which get merged, for example dependabot or just ci robot, so AI agents may not be much different. Do you think @tenzen-y this is enough? or we shoukd dig deeper? I think if we need authority we may need to consult the cncf slack channels. |
I just raised the discussions. So, I do not have a strong opinion to block this PR for now. |
|
Ok I also started a topic on the sig-contribx channel i was recommeneded to. While i think 99 percent it is ok, I suggest to change the PR, and we will try to learn going forward |
5 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
Promote AdmissionFairSharing to beta
Which issue(s) this PR fixes:
Fixes #7459
Special notes for your reviewer:
Updates the AdmissionFairSharing feature to beta status for v0.15:
🤖 Assisted with Claude Code
Does this PR introduce a user-facing change?