Skip to content

Fix duplicate key error when adding multiple labels with --without-selector #5991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2025
+14 −1
Merged

Fix duplicate key error when adding multiple labels with --without-selector #5991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9df8bbd
fix(cmd-edit-add-label): dubplicate key error
isarns Oct 5, 2025
d427f61
test(cmd-edit-add-label): add multiple labels without selector test
isarns Oct 12, 2025
f71e4d7
style(cmd-edit-add-label): lint multiple labels without selector test
isarns Oct 12, 2025
4d37afe
style(cmd-edit-add-label): lint multiple labels without selector test
isarns Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kustomize/commands/edit/add/addmetadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func (o *addMetadataOptions) writeToLabels(m *types.Kustomization, kind kindOfAd
}
continue
}
if err := o.writeToMap(lbl.Pairs, kind); err != nil {
if err := o.writeToMapEntry(lbl.Pairs, k, v, kind); err != nil {
return err
}
m.Labels = append(m.Labels, lbl)
Expand Down
13 changes: 13 additions & 0 deletions kustomize/commands/edit/add/addmetadata_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,19 @@ func TestAddLabelWithoutSelector(t *testing.T) {
},
},
},
{
name: "add multiple labels without selector",
baseLabels: []types.Label{},
options: addMetadataOptions{
labelsWithoutSelector: true,
metadata: map[string]string{"test1": "a", "test2": "b"},
},
expected: []types.Label{
{
Pairs: map[string]string{"test1": "a", "test2": "b"},
},
},
},
{
name: "overwrite label with same settings",
baseLabels: []types.Label{
Expand Down
Loading