Skip to content

Conversation

@rfranzke
Copy link
Contributor

Follow-up of 063ede9

This PR introduces a minimal Gardener provider for the multicluster-runtime project, enabling integration with Gardener's multi-cluster management. The provider supports two flavors:

  • garden Flavor: Controller interacts with the garden cluster, watches Shoot resources, and uses short-lived, auto-renewed admin kubeconfigs.
  • seed Flavor: Controller connects to a seed cluster, watches Cluster resources, and leverages the gardenlet's short-lived, auto-renewed cluster-admin kubeconfig.

Similar to #7

Without this:

```
2025-04-17T14:01:14+02:00	ERROR	Observed a panic	{"controller": "multicluster-configmaps", "controllerGroup": "", "controllerKind": "ConfigMap", "reconcileID": "3fb0db90-5921-4b92-89f2-70f5c2119843", "panic": "odd number of arguments passed as key-value pairs for logging", "stacktrace": ...}
```
Very similar to CAPI provider
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rfranzke
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from JeremyOT and embik April 22, 2025 08:21
@k8s-ci-robot
Copy link
Contributor

Welcome @rfranzke!

It looks like this is your first PR to kubernetes-sigs/multicluster-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/multicluster-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 22, 2025
@xrstf
Copy link

xrstf commented Apr 22, 2025

I think a better place for such implementations would be a repository in the Gardener GitHub organization, rather than here. This would simplify the PR reviews as Gardener folks could review their own stuff in their own repository, rather than having to contribute to one shared "village bicycle" repository here.

I don't think this repo here wants to become a monorepo holding various implementations from various authors at varying quality levels. That would create a sort of expectation that all providers in this repo are at least somewhat maintained, and the maintainers here simply cannot provide that guarantee.

@rfranzke
Copy link
Contributor Author

Good points @xrstf! @embik and @mjudeikis shared similar thoughts. Let's
/close
this PR accordingly. Perhaps,

6. multicluster-runtime is provider agnostic, but may contain providers with its own go.mod files and dedicated OWNERS files.
should be adapted to prevent others from proposing similar providers here :)

@k8s-ci-robot
Copy link
Contributor

@rfranzke: Closed this PR.

In response to this:

Good points @xrstf! @embik and @mjudeikis shared similar thoughts. Let's
/close
this PR accordingly. Perhaps,

6. multicluster-runtime is provider agnostic, but may contain providers with its own go.mod files and dedicated OWNERS files.
should be adapted to prevent others from proposing similar providers here :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xrstf
Copy link

xrstf commented Apr 22, 2025

Perhaps, [...] should be adapted to prevent others from proposing similar providers here :)

Absolutely agree on that point :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants