-
Notifications
You must be signed in to change notification settings - Fork 38
✨ Add Gardener provider #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Without this:
```
2025-04-17T14:01:14+02:00 ERROR Observed a panic {"controller": "multicluster-configmaps", "controllerGroup": "", "controllerKind": "ConfigMap", "reconcileID": "3fb0db90-5921-4b92-89f2-70f5c2119843", "panic": "odd number of arguments passed as key-value pairs for logging", "stacktrace": ...}
```
Very similar to CAPI provider
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @rfranzke! |
|
I think a better place for such implementations would be a repository in the Gardener GitHub organization, rather than here. This would simplify the PR reviews as Gardener folks could review their own stuff in their own repository, rather than having to contribute to one shared "village bicycle" repository here. I don't think this repo here wants to become a monorepo holding various implementations from various authors at varying quality levels. That would create a sort of expectation that all providers in this repo are at least somewhat maintained, and the maintainers here simply cannot provide that guarantee. |
|
Good points @xrstf! @embik and @mjudeikis shared similar thoughts. Let's multicluster-runtime/README.md Line 47 in 7e76384
|
|
@rfranzke: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Absolutely agree on that point :-) |
Follow-up of 063ede9
This PR introduces a minimal Gardener provider for the multicluster-runtime project, enabling integration with Gardener's multi-cluster management. The provider supports two flavors:
gardenFlavor: Controller interacts with the garden cluster, watchesShootresources, and uses short-lived, auto-renewed admin kubeconfigs.seedFlavor: Controller connects to a seed cluster, watchesClusterresources, and leverages thegardenlet's short-lived, auto-renewed cluster-admin kubeconfig.Similar to #7