Skip to content

source/kernel: Add kvm availability #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
seungukshin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

source/kernel: Add kvm availability #2367

seungukshin wants to merge 1 commit into from
+58 −0

Conversation

@seungukshin
Copy link

@seungukshin seungukshin commented Nov 7, 2025

Add support for testing if a node can use virtualization for use by kata-containers (see https://katacontainers.slack.com/archives/C879ACQ00/p1761731112286659). On AMD and Intel platforms this can be determined with CPU feature flags, but on arm64 the situation is more complex. There 2 two flags - ID_AA64PFR0_EL1.EL2 (doc) and ID_AA64MMFR1_EL1.VH (doc)

  • ID_AA64PFR0_EL1.EL2 & 0b0001 != 0 (kernel runs at EL1, hyp world at EL2 - nVHE)
  • ID_AA64MMFR1_EL1.VH & 0b0001 != 0 (kernel is at EL2 using VHE), not visible from user space

Instead, check if kvm is initialized and has created /sys/devices/virtual/misc/kvm.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: seungukshin / name: Seunguk Shin (e7cbed9)

@netlify
Copy link

netlify bot commented Nov 7, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit e7cbed9
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-nfd/deploys/693c2b23334c540008fabb40
😎 Deploy Preview https://deploy-preview-2367--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2025

Welcome @seungukshin!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2025

Hi @seungukshin. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2025
marquiz
marquiz reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @seungukshin for the contribution. Could you sign the CLA?

@marquiz
Copy link
Contributor

marquiz commented Dec 9, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2025
@seungukshin
Copy link
Author

seungukshin commented Dec 9, 2025

Thank you @seungukshin for the contribution. Could you sign the CLA?

Thank you @marquiz and sorry for the delay.
I'm working on CLA from my company side, and probably I could proceed this this week.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 10, 2025
@marquiz
Copy link
Contributor

marquiz commented Dec 10, 2025

I'm working on CLA from my company side, and probably I could proceed this this week.

No problem

@seungukshin seungukshin force-pushed the kvm branch 2 times, most recently from 52d9f6c to d6c54b3 Compare December 11, 2025 17:07
marquiz
marquiz approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @seungukshin, looks good to me now.

One ask: could you rebase so that we get rid of the CI netlify errors?`

/assign @fmuyassarov @ArangoGutierrez

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, seungukshin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2025
@seungukshin
source/kernel: Add kvm availability
e7cbed9 
This commit adds a feature to check kvm availability.

Signed-off-by: Seunguk Shin <[email protected]>
Reviewed-by: Nick Connolly <[email protected]>
@seungukshin
Copy link
Author

seungukshin commented Dec 12, 2025

Thank you @marquiz for your review.

One ask: could you rebase so that we get rid of the CI netlify errors?`

I forgot syncing my forked repo. I just rebased it.

@marquiz
Copy link
Contributor

marquiz commented Dec 15, 2025

ping @fmuyassarov @ArangoGutierrez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

Assignees

@ArangoGutierrez ArangoGutierrez

@fmuyassarov fmuyassarov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seungukshin @k8s-ci-robot @marquiz @ArangoGutierrez @fmuyassarov