feat(FR-1764): add data-testid to agent live stats to hide it easily #4773
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.37% | 517/11818 |
| 🔴 | Branches | 3.59% | 298/8308 |
| 🔴 | Functions | 2.63% | 95/3615 |
| 🔴 | Lines | 4.35% | 503/11559 |
Test suite run success
145 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from c6e4235
ironAiken2
left a comment
ironAiken2
left a comment
There was a problem hiding this comment.
I've left a review regarding the naming convention.
nowgnuesLee
force-pushed
the
feat/add-data-testid-aget-live-stats
branch
from
221d71a to
3e35127
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds data-testid attributes to agent live statistics components to facilitate easier testing and programmatic hiding/showing of these elements.
Key Changes
- Added
data-testidattributes to CPU and memory live stat components - Added
data-testidattributes to device-specific stats (GPU, accelerator util/mem, power, temperature, network) - Added
data-testid="agent-list"to the main AgentList container component
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
agatha197
left a comment
agatha197
left a comment
There was a problem hiding this comment.
Please review sunchul's and copilot's review
nowgnuesLee
force-pushed
the
feat/add-data-testid-aget-live-stats
branch
from
3e35127 to
33df56c
Compare
Merge activity
|
…4773) resolves #4772 (FR-1764) In this pr, I added data-testid attribute to agent live stat to hide it easily. **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
graphite-app
bot
force-pushed
the
feat/add-data-testid-aget-live-stats
branch
from
33df56c to
c6e4235
Compare
resolves #4772 (FR-1764)
In this pr, I added data-testid attribute to agent live stat to hide it easily.
Checklist: (if applicable)