[13.x] Match the typehints for the make method on the App facade to those in the Application class

[willrowe]

This PR updates the typehints for the make method on the 'App' facade to match those on the make method in the Illuminate\Foundation\Application class that it calls. The app helper function already has this, which is great, but sometimes I'm using the facade and want the assigned variable to resolve to the correct type in my editor.

[cosmastech]

I believe this will be overwritten by https://github.com/laravel/facade-documenter which runs on merge

[willrowe]

@cosmastech good catch, checking it now.

[willrowe]

I just ran a test with https://github.com/laravel/facade-documenter/blob/main/facade.php locally and it is pulling out the wrong typehints for some reason. Looking into it further now.

[willrowe]

So it appears to be an issue in the facade documenter itself. Any idea why it's rewriting the docblocks instead of just copying them?

[cosmastech]

So it appears to be an issue in the facade documenter itself. Any idea why it's rewriting the docblocks instead of just copying them?

I am not sure if this is was an oversight or intentional. Maybe @timacdonald can shed some light.

It's been something that has been on my "open-source todos" list for a while, but never attempted.

[willrowe]

It's been something that has been on my "open-source todos" list for a while, but never attempted.

What specifically? What this PR is trying to do or something else?

[cosmastech]

It's been something that has been on my "open-source todos" list for a while, but never attempted.

What specifically? What this PR is trying to do or something else?

Modifying the facade documenter to keep the typehints that have been written and so painstakingly reviewed by Taylor 😆

[willrowe]

@cosmastech understood, I agree that it is expected that they would be preserved. I'm glad to submit a PR if @timacdonald can provide some context as to why it is working this way currently.

[willrowe]

I think it has something to do with how syntax supported in @return may not necessarily be valid in @method.