Skip to content

Conversation

@daniser
Copy link
Contributor

@daniser daniser commented Sep 11, 2025

Looking at this code, getDefaultDriver definitely can return null:

$driver = $driver ?: $this->getDefaultDriver();
if (is_null($driver)) {
throw new InvalidArgumentException(sprintf(
'Unable to resolve NULL driver for [%s].', static::class
));
}

This PR adjusts typehint on abstract method in Manager class itself, and also in SessionManager because it has nullable default config value.

@taylorotwell taylorotwell merged commit e5c338b into laravel:12.x Sep 12, 2025
65 checks passed
tegos pushed a commit to tegos/laravel-framework that referenced this pull request Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants