Skip to content

[12.x] Simplify driver instance decoration in manager #57025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniser wants to merge 1 commit into from
Closed

[12.x] Simplify driver instance decoration in manager #57025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Illuminate/Support/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,21 @@ public function driver($driver = null)
// If the given driver has not been created before, we will create the instances
// here and cache it so we can return it next time very quickly. If there is
// already a driver created by this name, we'll just return that instance.
return $this->drivers[$driver] ??= $this->createDriver($driver);
return $this->drivers[$driver] ??= $this->decorateInstance(
$this->createDriver($driver), $driver
);
}

/**
* Optionally decorate a driver instance.
*
* @param mixed $instance
* @param string $driver
* @return mixed
*/
protected function decorateInstance($instance, $driver)
{
return $instance;
}

/**
Expand Down