Draft:[12.x] Fix CallQueuedClosure::displayName after batch chain (#57597) #57881
+67
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
CreareWorks
force-pushed
the
fix/57597-batch-closure-chain-fix
branch
3 times, most recently
from
4c5cae9 to
77ca4d0
Compare
CreareWorks
force-pushed
the
fix/57597-batch-closure-chain-fix
branch
from
77ca4d0 to
a5bdd42
Compare
CreareWorks
changed the title
CreareWorks
force-pushed
the
fix/57597-batch-closure-chain-fix
branch
3 times, most recently
from
c0f7810 to
0928e51
Compare
…57597) This fixes a fatal error (`Call to undefined method Closure::getClosure()`) when a Closure is placed immediately after a Bus::batch call within a Bus::chain. The issue arose because the Closure object was passed as a raw `\Closure` instance to `CallQueuedClosure::displayName`, which incorrectly assumed it was always wrapped in a `SerializableClosure` and tried to call `getClosure()`. This patch adds a check to safely extract the underlying Closure, preventing the crash. Fixes laravel#57597
CreareWorks
force-pushed
the
fix/57597-batch-closure-chain-fix
branch
from
0928e51 to
cfac4d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a fatal error (
Call to undefined method Closure::getClosure()) when a Closure is placed immediately after a Bus::batch call within a Bus::chain.The issue arose because the Closure object was passed as a raw
\Closureinstance toCallQueuedClosure::displayName, which incorrectly assumed it was always wrapped in aSerializableClosureand tried to callgetClosure().This patch adds a check to safely extract the underlying Closure, preventing the crash.
Fixes #57597