chore: Introducing Synchronizer protocol & streaming implementation #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sdk-1390/fdv2-streaming
branch
3 times, most recently
from
659f6e2 to
19fa296
Compare
keelerm84
commented
Jul 30, 2025
| You have been warned. | ||
| """ | ||
|
|
||
| from abc import abstractmethod |
Member
Author
There was a problem hiding this comment.
Moving the shared types to this top level. In my next bit of work, I'm going to be re-arranging the polling stuff, so just focus on streaming for now.
kinyoklion
reviewed
Jul 30, 2025
kinyoklion
reviewed
Jul 30, 2025
Member
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
keelerm84
force-pushed
the
mk/sdk-1390/fdv2-streaming
branch
from
fa4c35f to
8cd1ce6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kinyoklion
reviewed
Jul 31, 2025
Member
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
Looks like some imports need sorting for CI. But I think everything makes sense.
kinyoklion
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.