Skip to content

Conversation

@keelerm84
Copy link
Member

@keelerm84 keelerm84 commented Oct 29, 2025

Note

Introduce SelectorStore and propagate selectors/basis through FDv2 initializers/synchronizers, updating polling/streaming to use it and adjusting tests/utilities.

  • Core API (protocols):
    • Add SelectorStore with selector(); update Initializer.fetch and Synchronizer.sync to accept SelectorStore.
  • Polling (ldclient/impl/datasourcev2/polling.py):
    • fetch/sync now take SelectorStore and pass ss.selector() to requester.
    • _poll builds Basis using headers and ChangeSet.selector.
  • Streaming (ldclient/impl/datasourcev2/streaming.py):
    • SseClientBuilder and create_sse_client accept SelectorStore; supply query_params with basis from selector.
    • sync now takes SelectorStore and uses new builder signature.
  • FDv2 orchestration (ldclient/impl/datasystem/fdv2.py):
    • Pass store (as SelectorStore) to initializers and synchronizers; consume updates accordingly.
  • Testing & mocks:
    • Update tests to pass MockSelectorStore with Selector.no_selector(); add MockSelectorStore.
    • Test data source V2: adapt to new method signatures; replace close() with stop().

Written by Cursor Bugbot for commit bf82505. This will update automatically on new commits. Configure here.

@keelerm84 keelerm84 requested a review from a team as a code owner October 29, 2025 17:07
@keelerm84 keelerm84 force-pushed the mk/sdk-1513/contract-tests branch from e55dca5 to 9c3cd49 Compare October 30, 2025 20:41
@keelerm84 keelerm84 force-pushed the mk/sdk-1521/selector-threading branch from b57273e to bf82505 Compare October 30, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants