-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Limit accumulating canvas buffer #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario-launchdarkly
approved these changes
Dec 16, 2025
abelonogov-ld
pushed a commit
that referenced
this pull request
Dec 16, 2025
🤖 I have created a release *beep* *boop* --- ## [0.14.0](0.13.1...0.14.0) (2025-12-16) ### Features * Flush buffers on going to app switcher ([#104](#104)) ([1cd74be](1cd74be)) * Limit accumulating canvas buffer ([#101](#101)) ([0a531f5](0a531f5)) ### Bug Fixes * UIDevice.current.orientation.isLandscape not main thread access ([#102](#102)) ([d8ffa0a](d8ffa0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Prepare 0.14.0 release with changelog updates and version bumps across manifest, podspecs, and `sdkVersion`. > > - **Release 0.14.0** > - Update versions in `.release-please-manifest.json`, `LaunchDarklyObservability.podspec`, `LaunchDarklySessionReplay.podspec`, and `Sources/LaunchDarklyObservability/Version.swift`. > - Update `CHANGELOG.md` with features (flush buffers on app switcher, limit accumulating canvas buffer) and a bug fix (avoid non-main-thread access for device orientation). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 07363d2. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RRWeb Canvas is being updated by draw commands and they all kept in the browser memory. Pr makes SR to reset this Canvas cache by pushing FullSnapshot after 10mb of canvas payloads
Note
Tracks canvas payload size (~10MB limit) to decide between incremental draws and full snapshots, refactors event data types, and adds SessionReplay tests.
generatingCanvasSize/pushedCanvasSize; triggerFullSnapshotwhen exceeded; otherwise issue incrementaldrawImage.RRWebPlayerConstants, track per-eventcanvasSize, and update size after payload push (updatePushedCanvasSize).rr_dataURLintoExportImage.eventNode).EventDatawith specificWindowData,MouseInteractionData,MouseMoveEventData, andDomData(with transitionalcanvasSize).CanvasDrawData/AnyCommandto carrycanvasSize; adjust decoding inAnyEventData.pushPayload, flush accumulated canvas size inSessionReplayEventGenerator.GraphQLClient.endpointprivate.SessionReplayTeststarget and scheme entry.Written by Cursor Bugbot for commit 841f989. This will update automatically on new commits. Configure here.