Skip to content

Conversation

@SoftlySpoken
Copy link
Contributor

This PR includes several fixes and documentation improvements for the gpstore implementation:

  • Fixed file paths in gpstore properties files for parameters_dir and updates_dir
  • Added plugin prefix to all gpstore queries to ensure compatibility with Docker
  • Updated validation_params.csv with correct values
  • Improved documentation in the gpstore README to clarify validation and database loading steps

Copy link
Contributor

@qishipengqsp qishipengqsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other diff LGTM. Why the validation params file changes?

@SoftlySpoken
Copy link
Contributor Author

We re-uploaded the latest, correct validation_params.csv. The previous version contained incorrect values.

Copy link
Contributor

@qishipengqsp qishipengqsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qishipengqsp qishipengqsp merged commit 5a4f9d7 into ldbc:main Sep 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants