Check SASL mechanism credential requirements #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbucksch
reviewed
Mar 18, 2025
| return { | ||
| optional: ['authzid'], | ||
| required: ['username', 'password'] | ||
| required: [['username', 'password']] |
There was a problem hiding this comment.
Why is this change necessary? PLAIN has username + password, and OAuth2 has username + access token.
This would be a fairly small and targeted code change, if it wasn't for this API change.
(Thanks for implementing this!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connecting to a server which provided
X-OAUTH2andPLAINas SASL mechanisms,X-OAUTH2was selected despite no token being provided. Now multiple candidate sets of required credentials are tested per mechanism (such as username/password, username/saltedPassword, userKey/clientKey all matching for SCRAM-SHA-1).All tests pass, including a two more for a separate X-OAUTH2 mechanism.
X-OAUTH2will now only be selected if atokencredential is provided;passwordwill no longer be used in its place.