Skip to content

Conversation

@Freed-Wu
Copy link
Contributor

Fix some build problems.
Now

luarocks install luanativeobjects
cmake -Bbuild -DUSE_PRE_GENERATED_BINDINGS=OFF -DGENERATE_LUADOCS=OFF

can build successfully.

  • rename luanativeobjects executable file name
  • let json be an optional dependency

According to https://luarocks.org/modules/neopallium/luanativeobjects
the executable file name of luanativeobjects is native_objects
not native_objects.lua
if user `cmake -Bbuild -DGENERATE_LUADOCS=OFF`,
`require"json"` is not necessary
@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Dec 5, 2025

@Neopallium Can you add me to collaborators? Let me see what can I do 😄

@Neopallium Neopallium merged commit 1c89296 into libgit2:master Dec 16, 2025
@Neopallium
Copy link
Member

@Freed-Wu I can't add anyone to the project.

@Freed-Wu Freed-Wu deleted the build branch December 16, 2025 12:40
@Freed-Wu
Copy link
Contributor Author

Who have the permission? the maintainer of libgit2? @ethomson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants