Skip to content

fix stale comment in partialmessages #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcoPolo wants to merge 1 commit into
base: pm-fix-idontwant-omit-bug
Choose a base branch
from
Open

fix stale comment in partialmessages #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions partialmessages/partialmsgs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,10 @@ type Message interface {

// PartialMessageBytes takes in the opaque request metadata and
// returns a encoded partial message that fulfills as much of the request as
// possible. It also returns a opaque request metadata representing the
// parts it could not fulfill. This MUST be empty if the implementation could
// fulfill the whole request.
//
// An empty metadata should be treated the same as a request for all parts.
// possible.
//
// If the Partial Message is empty, the implementation MUST return:
// nil, metadata, nil.
// nil, nil.
PartialMessageBytes(partsMetadata PartsMetadata) (msg []byte, _ error)

PartsMetadata() PartsMetadata
Expand Down