-
-
Notifications
You must be signed in to change notification settings - Fork 528
chore: remove public piped instances #7920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: remove public piped instances #7920
Conversation
Drops support for public Piped instances. This is due to only a few (2) public instances still being online, neither of them supports streaming. As Piped development has stalled and due to increasing blocking from YouTube it's doubtful the situation will improve in the near future. Removing public Piped instances improves the user experience, as there are no longer cryptic errors displayed, sign-ups fails, etc. This does not remove support for piped instances overall, custom instances are still supported, with the assumption that self-hosting users are knowledgeable enough to handle the issues themselves. Ref: libre-tube#7915 Closes: libre-tube#7833
Removes the WelcomeActivity, as it no longer servers a purpose, with the removal of public Piped instances. For most users this screen only entails tapping on OK, whilst a minority may use the restore option, which is also accessible in the preferences.
48cbef1 to
9482397
Compare
|
Thinking about it, we probably should do a migration (to avoid users having the app not working anymore). |
Bnyro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a few (2) public instances still being online, neither of them supports streaming
The thing is that these two still allow you to search and load other data more anonymously - so using the "local streams extraction" with a public Piped instance is still a valid use case imo.
|
But it may stop working soon or in the future and we do not wait until it stops or until we receive new issue reports to start making fixes again |
|
I need to correct myself, it's only one instance, piped.syncpundit.io, doesn't provide an API.
Only partially, as the Piped backend uses an older extractor version, and as such doesn't have the fixes for videos with multiple creators, doesn't support content availability (thus still displays members-only videos), etc … I'm also not opposed to someone using Piped for such requests, however, I would prefer if users had to add such instances themselves, to provide a natural barrier from stopping new users using Piped and having issues with it. |

Drops support for public Piped instances. This is due to
This does not remove support for piped instances overall, custom instances are still supported, with the assumption that self-hosting users are knowledgeable enough to handle the issues themselves.
Future steps may include to merge the fetch instance with auth instance, as self-hosting users are unlikely to host two instance, and use one just for fetching channels.
Ref: #7915
Closes: #7833