Skip to content

Fix runtime exception in job scheduler initialization. #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −11
Open

Fix runtime exception in job scheduler initialization. #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/spark/src/main/java/com/linkedin/openhouse/jobs/scheduler/JobsScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import com.linkedin.openhouse.jobs.client.TablesClient;
import com.linkedin.openhouse.jobs.client.TablesClientFactory;
import com.linkedin.openhouse.jobs.client.model.JobConf;
import com.linkedin.openhouse.jobs.scheduler.tasks.DatabaseOperationTask;
import com.linkedin.openhouse.jobs.scheduler.tasks.JobInfo;
import com.linkedin.openhouse.jobs.scheduler.tasks.JobInfoManager;
import com.linkedin.openhouse.jobs.scheduler.tasks.OperationMode;
Expand Down Expand Up @@ -100,7 +101,8 @@ public class JobsScheduler {
.forEach(
subclass -> {
if (!subclass.equals(TableOperationTask.class)
&& !subclass.equals(TableDirectoryOperationTask.class)) {
&& !subclass.equals(TableDirectoryOperationTask.class)
&& !subclass.equals(DatabaseOperationTask.class)) {
try {
Field nameField = subclass.getDeclaredField("OPERATION_TYPE");
OPERATIONS_REGISTRY.put(
Expand Down
19 changes: 9 additions & 10 deletions apps/spark/src/test/java/com/linkedin/openhouse/jobs/scheduler/JobsSchedulerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,13 @@
import java.util.concurrent.TimeUnit;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestInstance;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;

@TestInstance(TestInstance.Lifecycle.PER_CLASS)
@Disabled(
"The jobs scheduler test class is disabled as it takes time to run. Enable it to test jobs scheduler locally")
public class JobsSchedulerTest {
@Mock private TablesClient tablesClient;
@Mock private JobsClient jobsClient;
Expand Down Expand Up @@ -293,12 +290,14 @@ public void testRunSequentialFetchSingleMode() {

@Test
void testRegistryIsInitialized() {
JobsScheduler.main(
new String[] {
"--type", TableRetentionTask.OPERATION_TYPE.getValue(),
"--tablesURL", "http://test.openhouse.com",
"--jobsURL", "http://test.openhouse.com",
"--cluster", "unused",
});
// This test is designed to fail if the JobsScheduler class cannot be initialized.
// The static initializer block in JobsScheduler performs a reflective scan of OperationTask
// subclasses. If any of these subclasses are abstract and not properly excluded, the
// class initialization will fail with an ExceptionInInitializerError.
Assertions.assertDoesNotThrow(
() -> {
Class.forName(JobsScheduler.class.getName());
},
"JobsScheduler class should be initialized without throwing an exception");
}
}