Add terminating rules support for Markov algorithms #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #12
This commit implements terminating rules across all three language implementations (C#, Python, and Nim) as requested in issue #12. Terminating rules allow for Markov algorithm behavior where a rule marked as terminating will stop the entire transformation process immediately after being applied. Changes: - Added IsTerminating property to ISubstitutionRule interface and SubstitutionRule class (C#) - Updated TextSteppedTransformer to handle terminating rule logic (C#) - Added comprehensive tests for terminating rules functionality (C#) - Added is_terminating field to SubRule class (Python) - Updated SteppedTranslator to handle terminating rules (Python) - Added terminating rule tests (Python) - Added isTerminating field to RuleObj (Nim) - Updated transform function to handle terminating rules (Nim) - Fixed Python imports for proper module loading The implementation maintains backward compatibility - existing rules continue to work unchanged, and the new terminating behavior is only activated when explicitly set. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
konard
changed the title
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation Details
C# Changes
IsTerminatingproperty toISubstitutionRuleinterfaceSubstitutionRuleclass with new constructors and implicit operators for terminating rulesTextSteppedTransformerto handle terminating rule logic correctlyPython Changes
is_terminatingfield toSubRuleclassSteppedTranslatorto process terminating rules and stop execution when appliedNim Changes
isTerminatingfield toRuleObjtypetransformfunction to handle terminating rules with immediate terminationTest Coverage
Test plan
🤖 Generated with Claude Code
Resolves #12