Add DSP_LIBRARY_PATH mappings for target machines #36
Conversation
machine_dsp_paths.yml
Outdated
| "Thundercomm Dragonboard 845c": | ||
| DSP_LIBRARY_PATH: "/sdm845/Thundercomm/db845c/" | ||
| "Qualcomm Technologies, Inc. Robotics RB5": | ||
| DSP_LIBRARY_PATH: "sm8250/Thundercomm/RB5/" |
There was a problem hiding this comment.
This line is not consistent with the rest of them. Why do we need the leading and trailing slash characters?
machine_dsp_paths.yml
Outdated
| "Qualcomm Technologies, Inc. QCS8300 Ride": | ||
| DSP_LIBRARY_PATH: "/qcs8300/Qualcomm/QCS8300-RIDE/" | ||
| "Qualcomm SA8775P Ride": | ||
| DSP_LIBRARY_PATH: "/sa8775p/Qualcomm/SA8775P-RIDE/" No newline at end of file |
machine_dsp_paths.yml
Outdated
| DSP_LIBRARY_PATH: "/qrb4210/Thundercomm/RB2/" | ||
| "Qualcomm Technologies, Inc. Robotics RB3gen2": | ||
| DSP_LIBRARY_PATH: "/qcm6490/Thundercomm/RB3gen2/" | ||
| "Qualcomm QCS9100 Ride Rev3": |
There was a problem hiding this comment.
You missed IQ boards which are also supported by the release.
quic-vkatoch
force-pushed
the
add-dsp-lib-paths
branch
from
226bef8 to
07619fc
Compare
|
This can very quickly become unmanageable. Could you please sort them (e.g. by the DSP path) and add a comment describing sorting order? Also please extend testing scripts. New DSP subdirs must have an entry in the config file. |
|
Can you also add |
Ack, I’ll sort them based on machine names so that other properties can be added if needed. I’ll also update the test scripts. |
Sure, will update. |
quic-vkatoch
force-pushed
the
add-dsp-lib-paths
branch
2 times, most recently
from
1d3d217 to
e4f55c4
Compare
quic-vkatoch
force-pushed
the
add-dsp-lib-paths
branch
from
e4f55c4 to
dc8a830
Compare
Makefile
Outdated
|
|
||
| install: | ||
| ./scripts/install.sh config.txt ${DESTDIR}/${DSPDIR} | ||
| install -D -m 0644 machine_dsp_paths.yml ${DESTDIR}/${DSPDIR}/conf.d/machine_dsp_paths.yml |
There was a problem hiding this comment.
00-hexagon-dsp-binaries.yaml
There was a problem hiding this comment.
Ack, renamed file to 00-hexagon-dsp-binaries.yaml and updated Makefile and check.py accordingly.
Add DSP_LIBRARY_PATH entries in a new YAML file for the supported machines to enable consistent, machine-specific DSP library resolution. The machine entries are sorted alphabetically by machine name to ensure maintainability and stability as new properties are added in the future. Update the Makefile to install the YAML file to the conf.d directory alongside the DSP binaries. Signed-off-by: Vinayak Katoch <[email protected]>
Add validation to ensure paths in config.txt exist in 00-hexagon-dsp-binaries.yaml, reporting each missing path once. Signed-off-by: Vinayak Katoch <[email protected]>
quic-vkatoch
force-pushed
the
add-dsp-lib-paths
branch
from
dc8a830 to
4121b85
Compare
3 participants
Add DSP_LIBRARY_PATH entries in a new YAML file for the supported machines to enable consistent, machine-specific DSP library resolution.
The machine entries are sorted alphabetically by machine name to ensure maintainability and stability as new properties are added in the future. Also update the test script (check.py) to validate that paths in config.txt are consistent with entries in 00-hexagon-dsp-binaries.yaml, and update the Makefile to install the YAML file to the conf.d directory alongside the DSP binaries.