-
Notifications
You must be signed in to change notification settings - Fork 180
fix: expand support for long filenames on ulnfs #3397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added "ulnfs" to the list of filesystems supporting long filenames in FileUtils::supportLongName(). Task: https://pms.uniontech.com/task-view-381255.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExtend FileUtils::supportLongName() so that ULNFS-mounted paths are treated as supporting long filenames by including the "ulnfs" filesystem type in its internal whitelist. Class diagram for FileUtils::supportLongName long-filename filesystem updateclassDiagram
class FileUtils {
+QString normalPathToTrash(QUrl normal)
+bool supportLongName(QUrl url)
-static QList~QString~ longNameFsTypes
}
class dfmio_DFMUtils {
+static QString fsTypeFromUrl(QUrl url)
}
FileUtils ..> dfmio_DFMUtils : uses
%% Updated internal whitelist now includes ulnfs
class longNameFsTypes {
+vfat
+exfat
+ntfs
+ntfs3
+fuseblk
+fuse.dlnfs
+udf
+ulnfs
}
FileUtils *-- longNameFsTypes : contains
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepin pr auto review我来对这段代码的修改进行审查:
改进建议:
const static QList<QString> supportedFileSystems {
"vfat", "exfat", "ntfs", "ntfs3", "fuseblk", "fuse.dlnfs", "udf", "ulnfs"
};
const static QSet<QString> supportedFileSystems {
"vfat", "exfat", "ntfs", "ntfs3", "fuseblk", "fuse.dlnfs", "udf", "ulnfs"
};
// ulnfs: User Level Network File System support
const static QList<QString> supportedFileSystems {
// ... other file systems ...
"ulnfs"
};总的来说,这个修改是合理的,主要是增加了对新文件系统类型的支持。建议的改进主要是为了提高代码的可维护性和性能。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Johnson-zs, wangrong1069 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Added "ulnfs" to the list of filesystems supporting long filenames in FileUtils::supportLongName().
Task: https://pms.uniontech.com/task-view-381255.html
Summary by Sourcery
Bug Fixes: