Skip to content

[CIR] Fix assertion failure in applyReplacements when operation is not in block #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mingshi2333 wants to merge 1 commit into from
Closed

[CIR] Fix assertion failure in applyReplacements when operation is not in block #1959

mingshi2333 wants to merge 1 commit into from

Conversation

@mingshi2333
Copy link
Contributor

@mingshi2333 mingshi2333 commented Oct 28, 2025

This PR fixes an assertion failure that occurs in applyReplacements when an operation is not in a block.

Changes

  • Modified CIRGenModule.cpp to handle the case when operation is not in block
  • Added test case ctor-alias-complex.cpp to verify the fix

@mingshi2333 @factory-droid
[CIR] Fix assertion failure in applyReplacements when operation is no…
82be4ca 
…t in block

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@mingshi2333 mingshi2333 deleted the fix-applyReplacements-assertion branch October 28, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lanza lanza Awaiting requested review from lanza lanza is a code owner

@bcardosolopes bcardosolopes Awaiting requested review from bcardosolopes bcardosolopes is a code owner

@xlauko xlauko Awaiting requested review from xlauko xlauko is a code owner

@andykaylor andykaylor Awaiting requested review from andykaylor andykaylor is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mingshi2333