Skip to content

[RISCV][TTI] Fix crash of non-built-in vector type cost quering. #167258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

[RISCV][TTI] Fix crash of non-built-in vector type cost quering. #167258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96eaa94
[RISCV][TTI] Fix crash of non-built-in vector type cost quering.
ElvisWang123 Nov 10, 2025
af17252
!fixup, adderss comments.
ElvisWang123 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1683,7 +1683,8 @@ InstructionCost RISCVTTIImpl::getCastInstrCost(unsigned Opcode, Type *Dst,
!TypeSize::isKnownLE(DL.getTypeSizeInBits(Src),
SrcLT.second.getSizeInBits()) ||
!TypeSize::isKnownLE(DL.getTypeSizeInBits(Dst),
DstLT.second.getSizeInBits()))
DstLT.second.getSizeInBits()) ||
SrcLT.first > 1 || DstLT.first > 1)
return BaseT::getCastInstrCost(Opcode, Dst, Src, CCH, CostKind, I);

// The split cost is handled by the base getCastInstrCost
Expand Down
10 changes: 10 additions & 0 deletions llvm/test/Analysis/CostModel/RISCV/cast.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6239,3 +6239,13 @@ define void @legalization_crash() {
fptoui <192 x float> undef to <192 x i1>
ret void
}

; Test that BitInt cases won't crash at cost model.
Copy link
Contributor

@lukel97 lukel97 Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, maybe say that this is testing cases where one of the types needs to be split?

Suggested change
; Test that BitInt cases won't crash at cost model.
; Test that types that need to be split go through BasicTTIImpl

define void @BitInt_crash() {
; ZVE64X-LABEL: 'BitInt_crash'
; ZVE64X-NEXT: Cost Model: Found an estimated cost of 2043 for instruction: %1 = bitcast <16 x i64> poison to <512 x i2>
; ZVE64X-NEXT: Cost Model: Found an estimated cost of 0 for instruction: ret void
;
bitcast <16 x i64> poison to <512 x i2>
ret void
}
Loading