Disable clangd testing on Linaro quick bots #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes llvm/llvm-project#165336. Our quick bots run on a shared server with many other bots. Some are assigned cores, others are not. It's a bit chaotic but generally it works out. In this case, lately it has not for clangd tests. We could change the timeouts in clangd testing, but in theory the OS could stall a process for minutes. I don't want to make everyone else deal with that timeout just for our server. Instead, disable clangd tests on these bots and rely on the other bots who also run the tests but do not have this flakiness. For instance our single stage SVE bots and 2 stage Armv8 32-bit bot. This increases the response time for a clangd failure to around 30 minutes for AArch64 and 3 hours for Arm 32-bit. The latter is not great but I've not so far seen a clangd failure that was 32-bit specific, so I'm ok with the risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes llvm/llvm-project#165336.
Our quick bots run on a shared server with many other bots. Some are assigned cores, others are not. It's a bit chaotic but generally it works out. In this case, lately it has not for clangd tests.
We could change the timeouts in clangd testing, but in theory the OS could stall a process for minutes. I don't want to make everyone else deal with that timeout just for our server.
Instead, disable clangd tests on these bots and rely on the other bots who also run the tests but do not have this flakiness.
For instance our single stage SVE bots and 2 stage Armv8 32-bit bot.
This increases the response time for a clangd failure to around 30 minutes for AArch64 and 3 hours for Arm 32-bit. The latter is not great but I've not so far seen a clangd failure that was 32-bit specific, so I'm ok with the risk.