avoiding overwriting of tags with key named as 'tags' #10
Conversation
|
I have signed the CLA and i'm the member of elasticsearch. I have created the pull request for avoiding overwriting of tags with key named as 'tags' #10 . Kindly review the fix. |
|
hey @hselvara I'm not sure what happened during the creation of the PR, but your commit creates a new file instead of modifying |
hselvara
force-pushed
the
avoid_overwrite_of_tags
branch
from
2fd8df8 to
f98ae45
Compare
|
Hi @jsvd i have updated the PR. Please review. |
jsvd
left a comment
jsvd
left a comment
There was a problem hiding this comment.
few code style changes. also, can you add a test that shows what this feature allows? thank you
lib/logstash/codecs/fluent.rb
Outdated
|
|
||
| def encode(event) | ||
| tag = event.get("tags") || "log" | ||
| tag = event.get("tags") || "log" |
There was a problem hiding this comment.
please remove this indentation changes, this will make the PR less noisy and more concise.
There was a problem hiding this comment.
Yeah i completed that. Thanks for notifying
lib/logstash/codecs/fluent.rb
Outdated
| epochtime = entry[0] | ||
| map = entry[1] | ||
| event = LogStash::Event.new(map.merge( | ||
| arr= [] |
There was a problem hiding this comment.
please try to follow the core conventions present in this file. when assigning to a variable, we use spaces before and after the equals sign, so arr = [] instead of arr= []
There was a problem hiding this comment.
I mad the changes. Thanks for Notifying
|
Hi Jsvd, I have updated your comments. Please review |
|
@hselvara can you rebase, please? the PR now rewrites about 16 files for no apparent reason |
2 participants
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/