Skip to content

Conversation

@lrnv
Copy link
Owner

@lrnv lrnv commented Oct 9, 2025

Fixes #318

@lrnv lrnv merged commit cecedd6 into main Oct 9, 2025
3 checks passed
@lrnv lrnv deleted the lrnv/issue318 branch October 9, 2025 11:14
lrnv referenced this pull request Oct 9, 2025
@devmotion
Copy link

It might be useful to add a test to avoid regressions in a future release 🙂

@lrnv
Copy link
Owner Author

lrnv commented Oct 9, 2025

Indeed, will do that (edit: done in #321). In exchange, could you take another look at JuliaMath/SpecialFunctions.jl#506 ? 👼 😇

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.53%. Comparing base (269962c) to head (23774e3).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/SklarDist.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   78.55%   78.53%   -0.02%     
==========================================
  Files          85       85              
  Lines        4994     4995       +1     
==========================================
  Hits         3923     3923              
- Misses       1071     1072       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@devmotion
Copy link

It's on my TODO list, I plan to do a proper review beginning of next week.

@lrnv
Copy link
Owner Author

lrnv commented Oct 9, 2025

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Sklardist got picky

3 participants