CI: Always upload package cache even if overall build fails #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we don't trigger CI for more than 1 week, or if the gettext/libsodium packages were updated, CI needs to re-generate the artifacts and cache them. However, if the overall build fails later due to unrelated test failures, previously it would stop the cache from being uploaded at all, making iterating on fixing the test failure quite painful as we need to rebuild the artifact every run until it passes. This change now makes it so we always upload the cache as long as the package was built correctly, so that CI runs after the first failure will be much smoother.
ychin
added
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we don't trigger CI for more than 1 week, or if the gettext/libsodium packages were updated, CI needs to re-generate the artifacts and cache them. However, if the overall build fails later due to unrelated test failures, previously it would stop the cache from being uploaded at all, making iterating on fixing the test failure quite painful as we need to rebuild the artifact every run until it passes. This change now makes it so we always upload the cache as long as the package was built correctly, so that CI runs after the first failure will be much smoother.