Skip to content

optimize dockerfile #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

optimize dockerfile #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ FROM ubuntu:16.04

# Update repos and install dependencies
RUN apt-get update \
&& apt-get -y upgrade \
Copy link
Contributor Author

@jingsam jingsam Nov 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not run apt-get upgrade in docker, use a new version of image instead, eg. Ubuntu:18.04.

&& apt-get -y install build-essential libsqlite3-dev zlib1g-dev
&& apt-get -y install build-essential libsqlite3-dev zlib1g-dev \
&& rm -rf /var/lib/apt/lists/*
Copy link
Contributor Author

@jingsam jingsam Nov 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove apt cache, which make the docker image smaller and cleaner.


# Create a directory and copy in all files
RUN mkdir -p /tmp/tippecanoe-src
Expand Down