Skip to content

Add configurable threshold for rotate gesture snapping to north #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 31, 2025
Merged

Add configurable threshold for rotate gesture snapping to north #3914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
12fa8c8
Add configurable threshold for rotate gesture snapping to north
JesseCrocker Oct 27, 2025
cc3e096
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 27, 2025
b1925f2
Merge branch 'main' into ios-rotate-snap-threshold
JesseCrocker Oct 27, 2025
b833ec1
fix variable name in docs
JesseCrocker Oct 28, 2025
d8a6eff
Merge remote-tracking branch 'jesse/ios-rotate-snap-threshold' into i…
JesseCrocker Oct 28, 2025
58fdab4
update variable name
JesseCrocker Oct 28, 2025
298d249
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 28, 2025
2ddf770
Merge branch 'main' into ios-rotate-snap-threshold
JesseCrocker Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions platform/ios/src/MLNMapView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,15 @@ vertically on the map.
*/
@property (nonatomic, getter=isRotateEnabled) BOOL rotateEnabled;

/**
The threshold, measured in degrees, that determines when the map's bearing will snap to north.
For example, with a toleranceForSnappingToNorth of 7, if the user rotates the map within 7 degrees
of north, the map will automatically snap to exact north.

The default value of this property is 7.
*/
@property (nonatomic) CGFloat toleranceForSnappingToNorth;

/**
A Boolean value that determines whether the user may change the pitch (tilt) of
the map.
Expand Down
8 changes: 3 additions & 5 deletions platform/ios/src/MLNMapView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,6 @@ typedef NS_ENUM(NSUInteger, MLNUserTrackingState) {
/// Initial zoom level when entering user tracking mode from a low zoom level.
const double MLNDefaultZoomLevelForUserTracking = 14.0;

/// Tolerance for snapping to true north, measured in degrees in either direction.
const CLLocationDirection MLNToleranceForSnappingToNorth = 7;

/// Distance threshold to stop the camera while animating.
const CLLocationDistance MLNDistanceThresholdForCameraPause = 500;

Expand Down Expand Up @@ -883,6 +880,7 @@ - (void)commonInitWithOptions:(MLNMapOptions*)mlnMapoptions
[self addGestureRecognizer:_rotate];
_rotateEnabled = YES;
_rotationThresholdWhileZooming = 3;
_toleranceForSnappingToNorth = 7;

_doubleTap = [[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(handleDoubleTapGesture:)];
_doubleTap.numberOfTapsRequired = 2;
Expand Down Expand Up @@ -6839,8 +6837,8 @@ - (void)unrotateIfNeededForGesture
[self unrotateIfNeededAnimated:YES];

// Snap to north.
if ((self.direction < MLNToleranceForSnappingToNorth
|| self.direction > 360 - MLNToleranceForSnappingToNorth)
if ((self.direction < self.toleranceForSnappingToNorth
|| self.direction > 360 - self.toleranceForSnappingToNorth)
&& self.userTrackingMode != MLNUserTrackingModeFollowWithHeading
&& self.userTrackingMode != MLNUserTrackingModeFollowWithCourse)
{
Expand Down