RD-888 Refactored Geocoding Control (WIP) #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesbaa
requested changes
Nov 3, 2025
Contributor
lesbaa
left a comment
lesbaa
left a comment
There was a problem hiding this comment.
All in, I like the look of Lit. But I'm guessing it's all still in progress?
I'm not a big fan of the label / goto code and I think there's definitely some places where the logic could do with some refactoring / simplifying if at all possible (I'm thinking those nested if / else if / else statements)
I'd love for us to get rid of as many of the headaches as possible from the previous implementation.
Also some form of testing (even if it's just the base use cases) would be good and the readme etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RD-888
Objective
Refactor the whole component into standalone component without svelte dependency
Description
Svelte has been removed, geocoder has been rewritten into Lit.js, it is now usable standalone, separate classes for MapLibre GL and MapTiler SDK were created, WIP
Acceptance
Manual testing in demos, WIP