[UX] Providing effective user feedback guidelines #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@andersonjeccel @RCheesley Please, check this |
RCheesley
requested changes
Jul 25, 2024
Member
RCheesley
left a comment
RCheesley
left a comment
There was a problem hiding this comment.
Hey folks!
I love the content in this PR, it really does help developers to understand how to do things better. Thanks @andersonjeccel !
I've made some suggestions, some common themes were:
- I think we should be consistent with using double quotes only for spoken speech and single quotes for everything else,
- Inline code needs to have two backticks, not one
- There were a few Vale issues outstanding which I've proposed fixes for
- A couple of places using 'enable/enabled' which I've suggested a more inclusive phrase for
- I think we don't need to capitalise Call To Action in a sentence, I think it's fine lower case.
- A couple of Vale corrections which are wonky - Form and Points when you're not referring to the physical Mautic features, suggest turning off Vale for that para.
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
RCheesley
requested changes
Aug 28, 2024
Member
RCheesley
left a comment
RCheesley
left a comment
There was a problem hiding this comment.
I just have a few small nitpicks with this now, but I really appreciate the content and think we can get this ready to merge pretty fast.
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Mautic documentation to include detailed guidelines on handling "No Results" scenarios.
It introduces the "No Results" template, explaining its structure and parameters, and emphasizes the importance of visibility, transparency, and orientation to enhance user experience.
The documentation provides practical implementation guidelines with examples for creating informative messages, calls-to-action (CTAs), and contextual explanations.