Skip to content

Conversation

@fakela
Copy link
Member

@fakela fakela commented Apr 16, 2024

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A vale fix and a small comment about extra line break (not sure if it's intentional)

@RCheesley RCheesley added this to the Mautic 5.1 milestone Apr 16, 2024
@fakela
Copy link
Member Author

fakela commented Apr 17, 2024

Comment resolved @RCheesley

@fakela fakela requested a review from RCheesley April 17, 2024 22:10
@RCheesley
Copy link
Member

Please rebase this to 5.x then we can review it accordingly. Main isn't used any more (might need to change the default branch on your fork?)

@fakela
Copy link
Member Author

fakela commented Apr 23, 2024

Please rebase this to 5.x then we can review it accordingly. Main isn't used any more (might need to change the default branch on your fork?)

will resolve it today

@RCheesley
Copy link
Member

@fakela we can't merge this until you rebase please! :)

@RCheesley
Copy link
Member

@fakela @favour-chibueze do you think this could be rebased please? Or cherry-picked and created on a new branch? It'll need to go into the 5.2, 6.0 and 7.x branches as this was merged in 5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants