Preset fix #13
Open
Preset fix #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devanshu-puri
force-pushed
the
preset-fix
branch
from
e6b6550 to
2748be4
Compare
|
Great, just fix some basic error due to duplicate declarations in Equilizer.jsx, and then it's ready to pull 👍🏻 |
|
@MeetCoding I didn't see any duplicate declarations can you clarify |
|
@MeetCoding can you please review it fast i need some pr and i have worked as per the requirements. |
baync180705
requested changes
Oct 23, 2025
There was a problem hiding this comment.
Hey @devanshu-puri Great work done, however some further improvements are needed.
- The code inside Equializers.jsx contains duplicate imports and a lot of dead code, after the jsx getting returned. had to comment that part out to test your code. please to fix that.
- Your code is failing the conventional commits check. Do look into that once.
- When I click on the reset button, it first shows the wrong alert (as you can see in the screenshot), please get that fixed as well.
and you've added a reset button, which shows the same alert as the load preset button when clicked.
- The project uses bun as the runtime and package manager. You have used node+npm for the same. Kindly check the readme for the setup instructions with bun once. The file bun.lock should be present instead.
Thank you for your contribution ! If you require any help, do let us know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.