Skip to content

Conversation

@lukewarlow
Copy link
Contributor

Description

Add a page for the new ::details-content pseudo element.

Motivation

To help web developers discover this new feature.

Additional details

Related issues and pull requests

Depends on: mdn/interactive-examples#2874

@lukewarlow lukewarlow requested a review from a team as a code owner December 6, 2024 11:58
@lukewarlow lukewarlow requested review from chrisdavidmills and removed request for a team December 6, 2024 11:58
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Dec 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Preview URLs

Flaws (48)

URL: /en-US/docs/Web/CSS/::details-content
Title: ::details-content
Flaw count: 48

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted

(comment last updated: 2025-01-03 16:35:12)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @lukewarlow. I've got a few comments for you to consider, but nothing too major.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukewarlow nice one.

I thought your updates looked great, but I thought the examples could use a bit of description/explanation. Because I worked on the allow-discrete animation stuff recently and it is still fresh in my head, I decided to edit the page directly and drop an explanation in. I hope that's OK with you.

I won't merge it yet, so you can check it out to make sure you are happy with it.

@chrisdavidmills
Copy link
Contributor

@lukewarlow, oooh, I also increased the transition duration to 600ms so that it is a bit easier to see what is happening. I also put the opacity transition first, as I thought it was easier to explain if I explained that one first.

@bsmth bsmth added the awaiting response Awaiting for author to address review/feedback label Dec 30, 2024
@bsmth
Copy link
Member

bsmth commented Jan 3, 2025

@chrisdavidmills shall we merge this one :)

@chrisdavidmills chrisdavidmills merged commit 19f0543 into mdn:main Jan 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting response Awaiting for author to address review/feedback Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants