-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(payment-stripe): OXXO payment provider support with configurable expiration #13805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4d7fe06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 74 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@angelbanderasudg is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
willbouch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @@ -131,7 +132,7 @@ abstract class StripeBase extends AbstractPaymentProvider<StripeOptions> { | |||
| res.shared_payment_token = extra?.shared_payment_token as | |||
| | string | |||
| | undefined | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops ;)
|
Hey @angelbanderasudg and thanks for the contribution. Sorry for the late review. This looks good to me. Can you maybe just resolve the conflicts? CC @shahednasser idk but we might want to document this |
|
@willbouch sorry for the inactivity, conflicts resolved :) |
Summary
What — What changes are introduced in this PR?
This pull request adds support for OXXO payments to the Stripe payment provider module. The main changes include the addition of a new
OxxoProviderService, updates to type definitions to support OXXO-specific options, and integration of the new service into the provider's exports and registration.Why — Why are these changes relevant or necessary?
I was testing the MedusaJs server, I live in México and here oxxo as a Payment method is very used.
How — How have these changes been implemented?
OxxoProviderServiceinstripe-oxxo.ts, which extendsStripeBaseand configures Stripe payment intents for OXXO, including expiration settings.StripeOptionsandPaymentIntentOptionstypes to includeoxxoExpiresDaysand OXXO-specific payment method options for intent configuration.OXXOto thePaymentProviderKeysenum for provider identification.Testing — How have these changes been tested, or how can the reviewer test the feature?
You need to launch the medusa server, add Stripe OXXO as Payment Provider in your Store Region (OXXO only works in México and with mxn currency) and set payment_method_data type to oxxo.
Also you need to allow oxxo payment as payment method in stripe and configure your stripe webhook to your medusa server
Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
Checklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsAdditional Context
#13804
Note
Adds OXXO payment support to the Stripe provider with configurable expiration days and updates intent option handling and typings.
OxxoProviderService(services/stripe-oxxo.ts): configurespayment_intentfor OXXO withexpires_after_days(defaults to3, configurable viaoptions.oxxoExpiresDays).src/index.tsand exported fromservices/index.ts.StripeOptionsaddsoxxoExpiresDays.PaymentIntentOptionsaddspayment_method_options.oxxo.expires_after_days.PaymentProviderKeysaddsOXXO.core/stripe-base.ts:normalizePaymentIntentParametersnow falls back tothis.paymentIntentOptions.payment_method_optionswhen not provided inextra.@medusajs/payment-stripe.Written by Cursor Bugbot for commit 4d7fe06. This will update automatically on new commits. Configure here.