Skip to content

fix(): Index integration tests flackyness #13953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Nov 5, 2025
Merged

fix(): Index integration tests flackyness #13953

merged 24 commits into from
Nov 5, 2025

Conversation

@adrien2p
Copy link
Member

@adrien2p adrien2p commented Nov 4, 2025 •
edited
Loading

What

  • Properly await index data readiness before querying

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1028529

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
api-reference Building Building Preview Comment Nov 5, 2025 9:26am
7 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
api-reference-v2 Ignored Ignored Preview Nov 5, 2025 9:26am
cloud-docs Ignored Ignored Preview Nov 5, 2025 9:26am
docs-ui Ignored Ignored Preview Nov 5, 2025 9:26am
docs-v2 Ignored Ignored Preview Nov 5, 2025 9:26am
medusa-docs Ignored Ignored Preview Nov 5, 2025 9:26am
resources-docs Ignored Ignored Preview Nov 5, 2025 9:26am
user-guide Ignored Ignored Preview Nov 5, 2025 9:26am

@adrien2p adrien2p marked this pull request as ready for review November 4, 2025 13:17
@adrien2p adrien2p requested a review from a team as a code owner November 4, 2025 13:17
@adrien2p
Copy link
Member Author

adrien2p commented Nov 4, 2025

still trying to identify the flackyness of the cart completion integration tests

@adrien2p
Copy link
Member Author

adrien2p commented Nov 4, 2025

@olivermrbl so far so good, the last two runs ran in one shot 👍

willbouch
willbouch approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@willbouch willbouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg thanks

@adrien2p
Copy link
Member Author

adrien2p commented Nov 4, 2025

I still need to get to the bottom of this weird failing test in the index 🫣

@adrien2p adrien2p requested a review from a team as a code owner November 5, 2025 08:13
@adrien2p
Copy link
Member Author

adrien2p commented Nov 5, 2025

@olivermrbl are you ok with merging that one?

olivermrbl
olivermrbl approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets do it!

@adrien2p adrien2p merged commit 9d9d039 into develop Nov 5, 2025
36 checks passed
This was referenced Nov 5, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Oct 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@willbouch willbouch willbouch approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees

No one assigned

Labels

team: medusa type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adrien2p @carlos-r-l-rodrigues @willbouch @olivermrbl