Suport device=None #1025
Merged
Suport device=None #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Dan-Flores
reviewed
Nov 7, 2025
Dan-Flores
approved these changes
Nov 7, 2025
Dan-Flores
approved these changes
Nov 7, 2025
scotts
reviewed
Nov 7, 2025
scotts
reviewed
Nov 7, 2025
scotts
approved these changes
Nov 7, 2025
Contributor
scotts
left a comment
scotts
left a comment
There was a problem hiding this comment.
Looks great! Approved to unblock, let's update the comments before merging.
NicolasHug
added a commit
to NicolasHug/torchcodec
that referenced
this pull request
Nov 11, 2025
This reverts commit b597922.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
device=Nonein VideoDecoderFixes #993
Summary
This PR implements support for
device=NoneinVideoDecoder, allowing it to use PyTorch's "current device" as determined by context managers and global settings.device=Noneis now the default parameter value.Backward Compatibility
device="cpu"ordevice="cuda"works exactly as beforecpubut rather PyTorch's device context if set.