Skip to content

Conversation

@Dan-Flores
Copy link
Contributor

@Dan-Flores Dan-Flores commented Dec 2, 2025

This PR removes transforms from the public _video_decoder.py API. To be certain, the torchcodec.transforms imports are removed.

  • test/test_transform_ops.py is deleted
  • The docs reference to transforms and its uses are deleted

The implementations in https://github.com/meta-pytorch/torchcodec/blob/main/src/torchcodec/transforms/_decoder_transforms.py and corresponding __init__.py are not deleted, as they are private classes, and cannot be used in _video_decoder.py after these changes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 2, 2025
@Dan-Flores Dan-Flores force-pushed the hide_transforms_for_release branch from 8acfa65 to 7ca5a6e Compare December 2, 2025 19:33
@Dan-Flores Dan-Flores changed the base branch from release/0.9 to main December 2, 2025 19:44
@Dan-Flores Dan-Flores changed the base branch from main to release/0.9 December 2, 2025 19:45
@Dan-Flores Dan-Flores force-pushed the hide_transforms_for_release branch 3 times, most recently from d339607 to 40daca7 Compare December 3, 2025 04:10
@Dan-Flores Dan-Flores force-pushed the hide_transforms_for_release branch from 40daca7 to 95ac6e9 Compare December 3, 2025 05:19
@Dan-Flores Dan-Flores marked this pull request as ready for review December 3, 2025 17:52
Copy link
Contributor

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM if CI is green, thanks @Dan-Flores . I'll approve but it's worth waiting for @scotts 's input

@scotts
Copy link
Contributor

scotts commented Dec 3, 2025

I think we should still remove this entire file:

from ._decoder_transforms import DecoderTransform, Resize # noqa
If we don't, users will still be able to see torchcodec.transforms and the two classes it exposes. And then I think we need to remove transforms from the top-level init:
from . import decoders, encoders, samplers, transforms # noqa

Copy link
Contributor

@scotts scotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we have successfully removed external evidence of my recent efforts from the next release. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants