-
Notifications
You must be signed in to change notification settings - Fork 74
Remove transforms from public decoder API #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/0.9
Are you sure you want to change the base?
Remove transforms from public decoder API #1085
Conversation
8acfa65 to
7ca5a6e
Compare
d339607 to
40daca7
Compare
40daca7 to
95ac6e9
Compare
NicolasHug
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM if CI is green, thanks @Dan-Flores . I'll approve but it's worth waiting for @scotts 's input
|
I think we should still remove this entire file:
torchcodec.transforms and the two classes it exposes. And then I think we need to remove transforms from the top-level init: torchcodec/src/torchcodec/__init__.py Line 12 in f2c8c69
|
scotts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think we have successfully removed external evidence of my recent efforts from the next release. :)
This PR removes transforms from the public
_video_decoder.pyAPI. To be certain, thetorchcodec.transformsimports are removed.test/test_transform_ops.pyis deletedtransformsand its uses are deletedThe implementations in https://github.com/meta-pytorch/torchcodec/blob/main/src/torchcodec/transforms/_decoder_transforms.py and corresponding
__init__.pyare not deleted, as they are private classes, and cannot be used in_video_decoder.pyafter these changes.