Delete cuda_tests.yaml -- we have cuda tests in linux_cuda_wheel.yaml #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
approved these changes
Oct 25, 2024
Contributor
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
LGTM but do we actually still need this job now that we have the wheels?
Contributor
Author
|
I don't think we need this. We had some C++ CUDA tests in my original August implementation that weren't tested by any other yml file. I actually got rid of those and now we only have pytests. I'll delete it to reduce the maintenance burden |
NicolasHug
approved these changes
Oct 25, 2024
NicolasHug
approved these changes
Oct 25, 2024
Contributor
|
Just rename this PR title before merging :) ! |
ahmadsharif1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting this file to reduce maintenance burden.
Initially I thought of keeping this one for C++ tests, etc. but we don't really have cuda C++ tests anymore