Add publishAverage config option to Datadog registry #6903
+39
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonatan-ivanov
left a comment
jonatan-ivanov
left a comment
There was a problem hiding this comment.
Could you please also add some tests?
| checkRequired("uri", DatadogConfig::uri)); | ||
| } | ||
|
|
||
| default boolean publishAverage() { |
Member
There was a problem hiding this comment.
See #6844 (comment), this should work for all the registries that publish avg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the enhancement discussed in #6844.
Summary
Adds a new publishAverage() boolean config option to DatadogConfig (default: true).
Updates DatadogMeterRegistry to conditionally publish .avg metrics for:
Timer
FunctionTimer
DistributionSummary
Ensures metadata for average metrics is also controlled by this flag.
Keeps existing 1.x behavior by default, while allowing users to disable average publishing if desired.
This aligns with the intended direction for 1.x and prepares the way for flipping the default in 2.x as discussed in #6843.
Feel free to suggest changes.