Skip to content

Conversation

@miljance
Copy link
Contributor

@miljance miljance commented Aug 17, 2025

Description

Sending an e-document using E-Documents module in sales means that as soon as a sales document is posted it will be sent to the service provider. This is fine in most of the cases. However, the cancelling process in some countries might be cumbersome. Therefore, it is desired that an E-document is sent out to the service provider only after it is assured that the invoice being sent is correct. With a new Workflow response, it is possible to create an E-Document during posting of a sales document without sending the document to the customer. If the posted invoice is ok - the action "Send Document" on E-Document card can be called manually.

Summary

  • New Status for E-Document: Exported.
  • New Workflow response added: 'Init E-Document using setup' which should be manually selected instead of the current one named 'Send E-Document using setup'
  • No new tests added as there was no test on sending side checking statuses - glad to add new ones if needed.
  • Waiting for the iniital feedback.

Work Item(s)

Fixes microsoft/BCApps#5004

Fixes AB#580686

@miljance miljance requested review from a team as code owners August 17, 2025 21:38
@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Aug 17, 2025
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Aug 18, 2025
@JesperSchulz JesperSchulz self-assigned this Aug 18, 2025
@JesperSchulz
Copy link
Contributor

@Groenbech96, could you take a look?

@Groenbech96
Copy link
Contributor

@miljance sounds like a clearance model scenario?

Is it some manual check that is done outside BC ?

@miljance
Copy link
Contributor Author

@miljance sounds like a clearance model scenario?

Is it some manual check that is done outside BC ?

No clearance outside BC. Just a manual check prior to sending it to the government portal. But if you are planning the clearance model with manual clearance in the BC that could also do the trick.

@Groenbech96
Copy link
Contributor

Ok. We just add some changes to the workflow bit and should be synced here #29098

Can you take a look at those and see how they make sense with your changes? :D

@miljance
Copy link
Contributor Author

Ah ok, that makes things a bit more different. There are two conflicting files, and I see that you have already introduced a similar Workflow response. I would need to test it with the new code. Also, I see you have not foreseen a new status for E-Document.
Which status do you set when waiting for Clearance? In-progress or processed? For me it fehlt we need a new status indicating that the E-Documents is waiting for something, but In-progress felt wrong as it is also used for immediate sending.

image

@miljance miljance force-pushed the EDocsTwoStepProcessingInSales branch from fed9d31 to 35b4b1f Compare August 31, 2025 19:21
@miljance
Copy link
Contributor Author

I have synced the changes with the new clearance model. As the clearance model provided all the needed functions, the change can be done much easier.

  • New Workflow Template
  • Setting the status to Exported for E-Document.

@Groenbech96 Can you check if the new changes fit? Please evaluate the naming of the workflow step.

@Groenbech96
Copy link
Contributor

I have synced the changes with the new clearance model. As the clearance model provided all the needed functions, the change can be done much easier.

  • New Workflow Template
  • Setting the status to Exported for E-Document.

@Groenbech96 Can you check if the new changes fit? Please evaluate the naming of the workflow step.

Can you use the new response E-Document exported using X? We added that with support for clearance model?

@Groenbech96
Copy link
Contributor

Groenbech96 commented Oct 1, 2025

I have synced the changes with the new clearance model. As the clearance model provided all the needed functions, the change can be done much easier.

  • New Workflow Template
  • Setting the status to Exported for E-Document.

@Groenbech96 Can you check if the new changes fit? Please evaluate the naming of the workflow step.

Do the new workflow step to export e-document
Also @miljance we moved e-docs to bcapps :)

@miljance
Copy link
Contributor Author

miljance commented Oct 1, 2025

I have synced the changes with the new clearance model. As the clearance model provided all the needed functions, the change can be done much easier.

  • New Workflow Template
  • Setting the status to Exported for E-Document.

@Groenbech96 Can you check if the new changes fit? Please evaluate the naming of the workflow step.

Do the new workflow step to export e-document Also @miljance we moved e-docs to bcapps :)

Hi @Groenbech96 - I can add another Workflow response but, in this case, it will do the same thing as for clearance model. So, if I create a new workflow response, do you expect it to do something else compared to clearance model? I mean the clearance model does exactly what I need - postpones the sending until resent manually. I am wondering, what is trigger for clearance model to actually send the document afterwards?

I also wondering if you see the changes I have made in regard to E-Document Status? The new Status called "Exported" might affect the clearance model as well.

My question, the clearance model exports the document first - and then - what is the trigger for actually sending the document?
image

@miljance
Copy link
Contributor Author

miljance commented Oct 3, 2025

@JesperSchulz Can the PR and the Issue be moved to BCApps as the E-Docs module has been moved to BCApps?

@JesperSchulz
Copy link
Contributor

@JesperSchulz Can the PR and the Issue be moved to BCApps as the E-Docs module has been moved to BCApps?

I'm afraid I can only move issues. The PR will have to get recreated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@miljance
Copy link
Contributor Author

miljance commented Oct 6, 2025

@JesperSchulz Thanks, I will create another PR over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BC Idea]: Two steps processing for E-Documents in the sales process

3 participants