Skip to content

Conversation

@karpikpl
Copy link
Contributor

@karpikpl karpikpl commented Mar 5, 2025

Updating dependencies

I've tested new version using this image: karpikpl/aik8s_troubleshoot:latest
which was build from new dockerfile -> https://github.com/microsoft/ApplicationInsights-Kubernetes/pull/380/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557

That Image uses dependency from the repository rather than nuget.

#382

@xiaomi7732
Copy link
Member

Please consider updating the default versions from 7.x to 8.x in src/Directory.Build.props as well.

@karpikpl
Copy link
Contributor Author

karpikpl commented Mar 6, 2025

Please consider updating the default versions from 7.x to 8.x in src/Directory.Build.props as well.

done in ce9795b

@xiaomi7732
Copy link
Member

It looks good to me. I'll merge this once 7.0.2 stable is out.

@xiaomi7732
Copy link
Member

Working on merging this on.

Copy link
Member

@xiaomi7732 xiaomi7732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me except there's 1 new github action that wouldn't work without the secrets. Do you mind remove it? Thanks.

@xiaomi7732 xiaomi7732 merged commit 122308d into microsoft:develop Jul 18, 2025
3 checks passed
@karpikpl karpikpl deleted the feature/update-packages branch July 19, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants