Dev/saars/fix stop overwriting sdk version #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR addresses issue #369 by introducing an option to control whether the internal SDK version in telemetry is overwritten. The changes update the telemetry initializer, its corresponding tests, and accompanying options configuration to support this new behavior.
- Updated tests to pass an IOptions parameter.
- Added the OverwriteSDKVersion flag in the options class with default behavior.
- Modified the telemetry initializer to conditionally overwrite the SDK version based on the provided option.
Reviewed Changes
| File | Description |
|---|---|
| tests/UnitTests/KubernetesTelemetryInitializerTests.cs | Updated constructor calls in tests to include options and added new tests for SDK version behavior. |
| src/ApplicationInsights.Kubernetes/Extensions/AppInsightsForKubernetesOptions.cs | Added a new boolean flag and summary comments to control SDK version overwriting. |
| tests/UnitTests/AppInsightsKubernetesOptionsTests.cs | Added a test ensuring the OverwriteSDKVersion flag defaults to false. |
| src/ApplicationInsights.Kubernetes/TelemetryInitializers/KubernetesTelemetryInitializer.cs | Updated constructor to inject options and modified Initialize to conditionally update the SDK version. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
karolz-ms
approved these changes
Mar 10, 2025
src/ApplicationInsights.Kubernetes/TelemetryInitializers/KubernetesTelemetryInitializer.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #369