Ability to exclude node information #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
xiaomi7732
requested changes
Aug 8, 2025
Member
xiaomi7732
left a comment
xiaomi7732
left a comment
There was a problem hiding this comment.
It looks largely good to me. Just 1 minor code consistency, please update the code to parse the option value in the constructor in K8sEnvironmentFactory class.
Refer to here as an example
…s it is not used.
Contributor
Author
|
@xiaomi7732 I updated what you mentioned. |
xiaomi7732
approved these changes
Aug 12, 2025
Contributor
Author
|
A test failed due to missing setup of |
Member
|
Will be released in 8.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some companies do not allow all pods to call the nodes api in the cluster,
Currently there is no way to skip the call to the nodes endpoint, which if you do not have the permission will potentially make noise in the logs showing a lot of failed (403 Forbidden) HTTP requests (see below).
K8sClientService.GetNodesAsyncignores the forbidden response, by returning an emptyIEnumerable<V1Node>, but the request is still being performed.This change adds an option to
ExcludeNodeInformation, which you can set totrue, if you want to skip the call to nodes endpoint entirely - typically because you don't have permission (and likely won't get it) to call the endpoint.