-
Notifications
You must be signed in to change notification settings - Fork 244
[Ignore] Workflow experiments #7417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjen1-msft
reviewed
Oct 31, 2025
This was referenced Nov 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target setup
Subject to change as tests are run.
Key Findings:
FIO comparison
fio --name=cpp-build --ioengine=libaio --direct=0 --rw=randrw --rwmixread=60 --bs=4k-256k --numjobs=18 --size=100M --nrfiles=50 --runtime=60 --time_based --group_reporting --directory=...Temp disk (d16ads)
Default OS Disk (d16as)
Details:
Configure a d8adsv5 with local temp disk, which is exposed as /mnt.
This may help our I/O issues, at it offers high IOPS caps: 9000 - 450000 IOPS (RR)
Build with clang-tidy takes 17 minutes with this configuration, versus 9 with the d16as. Is this because of CPU? Memory? Disk?
Oddly, on a 16 core machine where a ninja without arguments completes in 9 minutes:
Local build with clang-tidy seems to peak around 28Gb of memory usage, less than the 32Gb available to a d8adsv5, so it's probably not memory. Even so, and with the CI checks added, the job finishes in 30 minutes, faster than the main CI.
The debug build time also has doubled, from 3 to 6 minutes, which is surprising and different from local experiments with different -j values.
While the build is slower, the tests seem to run quite a bit faster (22 vs 28 minutes), and so Virtual CI is about 4 minutes quicker end to end that way than with the d16as.
-j8/10(default)/12 does not change the build time substantially on d8adsv5.
clang-tidy speedups
There is a caching wrapper called ctcache and it is published to pypi. Will update after results.
The default configuration for cltcache attempts to use
c++(gcc) to pre-process the files, rather than clang, which results in failure because we use -fcolor-diagnostic, which is only recognised by clang. With some tweaks, it's possible to get it to work, but there is no benefit on a single run, only on repeat runs.container pre-building
We could publish base containers to GHCR, and pull them from there to avoid the dependency set up phase. This means maintaining an extra job with write tokens however.
ACI in virtual too
With 1ES pools, there is no option other than local disk, which is very slow on C-ACI. Temp disks on VMSS offer much better throughput and are a preferable option for the majority of our end to end tests.