Wait for sealed secrets #7450
Merged
Wait for sealed secrets #7450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a race condition in recovery tests by implementing an explicit wait mechanism to ensure sealed secrets are fully written to disk before attempting to read them during node recovery. The solution adds a new wait_for_sealed_secrets() function that polls node logs to confirm sealed secrets have been flushed to disk.
Key changes:
- New helper function
wait_for_sealed_secrets()that monitors node logs for sealed secret completion messages - Strategic placement of wait calls before
save_sealed_ledger_secret()operations to prevent reading incomplete files - Additional synchronization before ledger rekey operations to ensure network stability
Co-authored-by: Copilot <[email protected]>
eddyashton
reviewed
Nov 12, 2025
achamayou
reviewed
Nov 12, 2025
achamayou
reviewed
Nov 12, 2025
achamayou
approved these changes
Nov 13, 2025
achamayou
added a commit
that referenced
this pull request
Nov 13, 2025
Co-authored-by: Copilot <[email protected]> Co-authored-by: Amaury Chamayou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @eddyashton 's comment on #7437 this PR explicitly waits for the sealed secrets to be available before proceeding.