Skip to content

Assignment Fix #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Assignment Fix #42

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
faf7dfe
Fixing bug where assignment is worng
mrm9084 Sep 27, 2024
d176130
Update test_feature_variants.py
mrm9084 Sep 27, 2024
7836fdb
Update test_feature_variants.py
mrm9084 Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions featuremanagement/_featuremanagerbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,13 @@ def _assign_variant(
if targeting_context.user_id in user_allocation.users:
evaluation_event.reason = VariantAssignmentReason.USER
variant_name = user_allocation.variant
elif feature.allocation.group and len(targeting_context.groups) > 0:
if not variant_name and feature.allocation.group and len(targeting_context.groups) > 0:
for group_allocation in feature.allocation.group:
for group in targeting_context.groups:
if group in group_allocation.groups:
evaluation_event.reason = VariantAssignmentReason.GROUP
variant_name = group_allocation.variant
elif feature.allocation.percentile:
if not variant_name and feature.allocation.percentile:
context_id = targeting_context.user_id + "\n" + feature.allocation.seed
box: float = self._is_targeted(context_id)
for percentile_allocation in feature.allocation.percentile:
Expand Down