Tag asserts for 2.51 (#25052)

## Description

Tag asserts for 2.51

Author: CraigMacomber

packages/dds/tree/src/simple-tree/api/schemaCompatibilityTester.ts

@@ -184,7 +184,7 @@ export class SchemaCompatibilityTester {
 		if (canUpgrade) {
 			assert(
 				allowsRepoSuperset(this.policy, stored, toStoredSchema(this.viewSchemaRoot)),
-				"View schema must be a superset of the stored schema to allow upgrade",
+				0xbf2 /* View schema must be a superset of the stored schema to allow upgrade */,
 			);
 		}
 

packages/dds/tree/src/simple-tree/discrepancies.ts

@@ -168,7 +168,7 @@ function getStoredNodeSchemaType(nodeSchema: TreeNodeStoredSchema): SchemaFactor
 	if (nodeSchema instanceof LeafNodeStoredSchema) {
 		return LeafNodeStoredSchema;
 	}
-	fail("Invalid stored node schema type");
+	fail(0xbe8 /* Invalid stored node schema type */);
 }
 
 function doesNodeKindMatchStoredNodeKind(
@@ -286,7 +286,7 @@ function* getNodeDiscrepancies(
 		case NodeKind.Object: {
 			assert(
 				isObjectNodeSchema(view),
-				"schema with node kind of object must implement ObjectNodeSchema",
+				0xbe9 /* schema with node kind of object must implement ObjectNodeSchema */,
 			);
 			const fields: SimpleKeyMap | undefined = view.flexKeyMap;
 			const differences = Array.from(
@@ -305,7 +305,7 @@ function* getNodeDiscrepancies(
 		case NodeKind.Array: {
 			assert(
 				isArrayNodeSchema(view),
-				"schema with node kind of array must implement ArrayNodeSchema",
+				0xbea /* schema with node kind of array must implement ArrayNodeSchema */,
 			);
 			const fields: SimpleKeyMap = new Map([
 				[
@@ -338,7 +338,7 @@ function* getNodeDiscrepancies(
 		case NodeKind.Map: {
 			assert(
 				isMapNodeSchema(view),
-				"schema with node kind of map must implement MapNodeSchema",
+				0xbeb /* schema with node kind of map must implement MapNodeSchema */,
 			);
 
 			yield* getFieldDiscrepancies(
@@ -352,7 +352,7 @@ function* getNodeDiscrepancies(
 		case NodeKind.Record: {
 			assert(
 				isRecordNodeSchema(view),
-				"schema with node kind of record must implement RecordNodeSchema",
+				0xbec /* schema with node kind of record must implement RecordNodeSchema */,
 			);
 
 			yield* getFieldDiscrepancies(
@@ -366,7 +366,7 @@ function* getNodeDiscrepancies(
 		case NodeKind.Leaf: {
 			assert(
 				view instanceof LeafNodeSchema,
-				"schema with node kind of leaf must implement LeafNodeSchema",
+				0xbed /* schema with node kind of leaf must implement LeafNodeSchema */,
 			);
 			// TODO: leafKind seems like a bad name
 			const viewValue = view.leafKind;
@@ -429,7 +429,10 @@ function* getFieldDiscrepancies(
 	// TODO: This is a temporary workaround until the comparison logic is redesigned.
 	viewKindIsSequence = false,
 ): Iterable<FieldDiscrepancy> {
-	assert(view instanceof FieldSchemaAlpha, "all field schema should be FieldSchemaAlpha");
+	assert(
+		view instanceof FieldSchemaAlpha,
+		0xbee /* all field schema should be FieldSchemaAlpha */,
+	);
 	const [viewExtra, storedExtra] = findExtraAllowedTypes(
 		view.annotatedAllowedTypesNormalized.types,
 		stored.types,
@@ -446,7 +449,7 @@ function* getFieldDiscrepancies(
 
 	const viewKind =
 		convertFieldKind.get(view.kind) ??
-		fail("A conversion from a FieldKind to a FlexFieldKind should exist");
+		fail(0xbef /* A conversion from a FieldKind to a FlexFieldKind should exist */);
 
 	// This checks if the field kind in the view schema is not compatible with the stored schema.
 	// We cannot detect if the view schema is a sequence using the kind property so it is passed in separately.
@@ -503,7 +506,7 @@ function* computeObjectNodeDiscrepancies(
 		if (storedSchema === undefined) {
 			const viewKind =
 				convertFieldKind.get(fieldSchema.kind) ??
-				fail("A conversion from a FieldKind to a FlexFieldKind should exist");
+				fail(0xbf0 /* A conversion from a FieldKind to a FlexFieldKind should exist */);
 			yield {
 				identifier,
 				fieldKey,
@@ -627,7 +630,7 @@ export function comparePosetElements<T>(
 	for (const extension of realizer) {
 		const aIndex = extension.get(a);
 		const bIndex = extension.get(b);
-		assert(aIndex !== undefined && bIndex !== undefined, "Invalid realizer");
+		assert(aIndex !== undefined && bIndex !== undefined, 0xbf1 /* Invalid realizer */);
 		if (aIndex < bIndex) {
 			hasLessThanResult = true;
 		} else if (aIndex > bIndex) {

packages/runtime/test-runtime-utils/src/assertionShortCodesMap.ts

@@ -807,7 +807,7 @@ export const shortCodeMap = {
 	"0x5c1": "local attribution keys should never be put in summaries",
 	"0x5c2": "trackable is invalid as it is not in a rooted merge tree.",
 	"0x5c8": "Unexpected kind",
-	"0x5c9": "Incremental Schema during update should be a allow a superset of the final schema",
+	"0x5c9": "Incremental Schema during update should allow a superset of the final schema",
 	"0x5cf": "Must allocate at least one ID",
 	"0x5d0": "Returned r11s snapshot is malformed. No trees!",
 	"0x5d1": "Returned r11s snapshot is malformed. No blobs!",
@@ -1514,7 +1514,6 @@ export const shortCodeMap = {
 	"0xa6f": "Pending changes must exist for rollback when collaborating",
 	"0xa70": "Pending changes must not exist when not collaborating",
 	"0xa71": "must have local change to ack",
-	"0xa72": "Invalid realizer",
 	"0xa73": "The typeField must be present in new JSON content",
 	"0xa74": "Expected object schema",
 	"0xa75": "the field must be an array node",
@@ -1697,7 +1696,6 @@ export const shortCodeMap = {
 	"0xb38": "Existing stored key should always map to a property key",
 	"0xb39": "missing schema",
 	"0xb3c": "missing schema for type in cursor",
-	"0xb3d": "tree adapter for stored adapter.output should not be never",
 	"0xb3f": "missing schema from context",
 	"0xb40": "missing simple-tree context",
 	"0xb41": "missing context",
@@ -1846,5 +1844,16 @@ export const shortCodeMap = {
 	"0xbe4": "expected reverse mapping and thus a string value",
 	"0xbe5": "expected reverse mapping and thus a key that is a normalized number",
 	"0xbe6": "New schema must allow all documents allowed by old schema",
-	"0xbe7": "entryPoint must be of type TreeRootDataObject"
+	"0xbe7": "entryPoint must be of type TreeRootDataObject",
+	"0xbe8": "Invalid stored node schema type",
+	"0xbe9": "schema with node kind of object must implement ObjectNodeSchema",
+	"0xbea": "schema with node kind of array must implement ArrayNodeSchema",
+	"0xbeb": "schema with node kind of map must implement MapNodeSchema",
+	"0xbec": "schema with node kind of record must implement RecordNodeSchema",
+	"0xbed": "schema with node kind of leaf must implement LeafNodeSchema",
+	"0xbee": "all field schema should be FieldSchemaAlpha",
+	"0xbef": "A conversion from a FieldKind to a FlexFieldKind should exist",
+	"0xbf0": "A conversion from a FieldKind to a FlexFieldKind should exist",
+	"0xbf1": "Invalid realizer",
+	"0xbf2": "View schema must be a superset of the stored schema to allow upgrade"
 };