Skip to content

Conversation

@Purva-Patki
Copy link
Contributor

Remmoved swagger usage
Fixed Build issues

@Purva-Patki Purva-Patki requested a review from Copilot August 22, 2025 04:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Swagger documentation from the Manager API and updates various NuGet package versions across the solution to fix build issues. The changes modernize dependencies and remove API documentation tooling.

  • Removed Swagger/OpenAPI documentation setup from Manager API
  • Updated Azure.Identity and Microsoft.Identity.Client packages to newer versions
  • Modernized build pipeline to use .NET 6.0 and NuGet 6.x

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Multiple .csproj files Updated Azure.Identity and Microsoft.Identity.Client package versions
LogClientInfoCommandHandler.cs Removed duplicate using statement
Startup.cs (Manager/Web/App) Updated authentication configuration to use Microsoft.Identity.Web
Startup.cs (Manager/Web/API) Removed Swagger configuration and endpoints
Manager API .csproj Removed Swagger packages and updated authentication packages
Manager Domain .csproj Switched CQRS package and removed SDK project reference
azure-pipelines.yml Updated to .NET 6.0 and NuGet 6.x with SSL dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


<ItemGroup>
<ProjectReference Include="..\..\..\..\sdk\Microsoft.UnifiedRedisPlatform.SDK\Core\Microsoft.UnifiedRedisPlatform.Core.csproj" />
<ProjectReference Include="..\..\..\..\service\Microsoft.UnifiedRedisPlatform.Service\SharedKernel\Common\Microsoft.UnifiedPlatform.Service.Common.csproj" />
Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project reference removal on line 11 may cause build issues if the Domain project depends on types from the Microsoft.UnifiedRedisPlatform.Core project. Verify that all dependencies are satisfied by the remaining references.

Suggested change
<ProjectReference Include="..\..\..\..\service\Microsoft.UnifiedRedisPlatform.Service\SharedKernel\Common\Microsoft.UnifiedPlatform.Service.Common.csproj" />
<ProjectReference Include="..\..\..\..\service\Microsoft.UnifiedRedisPlatform.Service\SharedKernel\Common\Microsoft.UnifiedPlatform.Service.Common.csproj" />
<ProjectReference Include="..\..\..\..\core\Microsoft.UnifiedRedisPlatform.Core\Microsoft.UnifiedRedisPlatform.Core.csproj" />

Copilot uses AI. Check for mistakes.

<ItemGroup>
<ProjectReference Include="..\..\..\sdk\Microsoft.UnifiedRedisPlatform.SDK\Core\Microsoft.UnifiedRedisPlatform.Core.csproj" />
<ProjectReference Include="../../../sdk/Core/Microsoft.UnifiedRedisPlatform.Core.csproj" />
Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project reference path has been changed from Windows-style backslashes to forward slashes. While this works on most systems, ensure this path is correct and the referenced project exists at this location.

Copilot uses AI. Check for mistakes.
<PackageReference Include="Microsoft.Graph.Auth" Version="1.0.0-preview.4" />
<PackageReference Include="Microsoft.IdentityModel.Clients.ActiveDirectory" Version="5.2.8" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="5.4.1" />
<PackageReference Include="Microsoft.Identity.Client" Version="4.73.1" />
Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Microsoft.IdentityModel.Clients.ActiveDirectory package was removed and replaced with Microsoft.Identity.Client. Ensure that any code using ADAL (Active Directory Authentication Library) has been migrated to MSAL (Microsoft Authentication Library) to avoid runtime errors.

Copilot uses AI. Check for mistakes.
@Purva-Patki
Copy link
Contributor Author

merging PR

@Purva-Patki Purva-Patki merged commit 4ea4234 into main Aug 22, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants